Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Tests for period-less float literals #1725

Merged
merged 1 commit into from
Feb 11, 2024
Merged

[test] Tests for period-less float literals #1725

merged 1 commit into from
Feb 11, 2024

Conversation

rossberg
Copy link
Member

Tests for parsing of float literals that are integers. Related to this wabt bug.

@rossberg rossberg requested a review from keithw February 11, 2024 07:41
keithw added a commit to WebAssembly/wabt that referenced this pull request Feb 11, 2024
keithw added a commit to WebAssembly/wabt that referenced this pull request Feb 11, 2024
Copy link
Member

@keithw keithw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Two of the new assertions (f64.min_int32 on line 184 and f64_dec.min_int32 on line 198) fail with wasm2c->MSVC (https://github.com/WebAssembly/wabt/actions/runs/7864206734/job/21455684596) and pass with the proposed fix.

@rossberg rossberg merged commit 29029b0 into main Feb 11, 2024
1 check passed
@rossberg rossberg deleted the float-lits branch February 11, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants